[go: up one dir, main page]
Skip to content

Decommission Marketo system hook

Production Change

Change Summary

Part of cleaning up marketo-tools.gitlap.com (https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/2331), we want to get rid of the system hook that's pointed at it. Deleting it normally is not tenable right now (see rationale in https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/2331#note_671931952), so it was suggested to change the web hook type from SystemHook to DeletedHook so it's no longer discoverable by the application.

Change Details

  1. Services Impacted - ServicePostgres
  2. Change Technician - @ahmadsherif
  3. Change Reviewer - @alejandro
  4. Time tracking - 10 minutes
  5. Downtime Component - none

Detailed steps for the change

Pre-Change Steps - steps to be completed before execution of the change

Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes

  • Set label changein-progress on this issue
  • As an admin, go to https://gitlab.com/admin/hooks, 1 web hooks pointing to marketo-tools.gitlap.com should be listed.

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - 5 minutes

  • ssh console-01-sv-gprd.c.gitlab-production.internal
  • sudo gitlab-rails c
  • h = WebHook.find(67407)
  • Make sure we fetched the correct hook: h.type == "SystemHook" # => true
  • h.update(type: 'ProjectHook') # => true

Post-Change Steps - steps to take to verify the change

Estimated Time to Complete (mins) - 1 minute

  • As an admin, go to https://gitlab.com/admin/hooks, no web hooks should be listed.

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - 5 minutes

  • ssh console-01-sv-gprd.c.gitlab-production.internal
  • sudo gitlab-rails c
  • h = WebHook.find(67407)
  • Make sure we fetched the correct hook: h.type == "ProjectHook" # => true
  • h.update(type: 'SystemHook') # => true

Monitoring

Key metrics to observe

  • Metric: Metric Name
    • Location: Dashboard URL
    • What changes to this metric should prompt a rollback: Describe Changes

Summary of infrastructure changes

  • Does this change introduce new compute instances?
  • Does this change re-size any existing compute instances?
  • Does this change introduce any additional usage of tooling like Elastic Search, CDNs, Cloudflare, etc?

Summary of the above

Changes checklist

  • This issue has a criticality label (e.g. C1, C2, C3, C4) and a change-type label (e.g. changeunscheduled, changescheduled) based on the Change Management Criticalities.
  • This issue has the change technician as the assignee.
  • Pre-Change, Change, Post-Change, and Rollback steps and have been filled out and reviewed.
  • This Change Issue is linked to the appropriate Issue and/or Epic
  • Necessary approvals have been completed based on the Change Management Workflow.
  • Change has been tested in staging and results noted in a comment on this issue.
  • A dry-run has been conducted and results noted in a comment on this issue.
  • SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
  • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
  • There are currently no active incidents.
Edited by Ahmad Sherif