[go: up one dir, main page]

Inconsistent tag behavior if specified in CLI and JSON file

If the tag is specified in both the CLI (directly, or via environment variable) and the JSON file (in either format), then the tag from the CLI is used to get CHANGELOG data, if applicable, but the tag from the JSON file is used in the release-cli command to create the release. So, you can end up with cases like the example shows below.

#!/bin/sh
release-cli create --name 'v1.0.0 (2020-11-21)' --description 'description for 1.0.0' --tag-name 0.5.0 --milestone 0.5.0

In addition, the release-cli command includes the tag_name if specified in the JSON file, but not if only specified via the CLI.

The application should ideally:

  • Check for inconsistent tags and throw error (that seems like a better approach than setting a priority, which may be different than release-cli)
  • Not require tags via if not required (i.e. if release file and tag specified)
  • Output tag_name to release-cli command if tag specified in any case. This may not be required if run in GitLab CI, but is at least explicit.
Edited by Aaron Goldenthal