[go: up one dir, main page]

Doesn't compile with libgit2 feature enabled and curl feature disabled

Siril version: 1.4.0

Operating System: Linux (Gentoo)

Package: Compiled from source to package for Gentoo

Description of the bug

The source code doesn't compile with libgit2 enabled and curl feature disabled.

Reproduction

Reproduction steps:

  1. meson setup ... -Dlibgit2=true -Dlibcurl=false ...
  2. Compile

Expected result:

Source compiles sucessfully

Actual result:

FAILED: [code=1] src/libsiril.a.p/core_siril_networking.c.o 
x86_64-pc-linux-gnu-gcc -Isrc/libsiril.a.p -Isrc -I../siril-1.4.0/src -Isubprojects/htmesh -I../siril-1.4.0/subprojects/htmesh -Isubprojects/healpix_cxx -I../siril-1.4.0/subprojects/healpix_cxx -Isubprojects/kplot -I../siril-1.4.0/subprojects/kplot -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/uuid -I/usr/include/json-c -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/webp -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/atk-1.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind -I/usr/include/fribidi -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/opencv4 -I/usr/include/wcslib -I/usr/include/gtksourceview-4 -I/usr/include/libxml2 -fdiagnostics-color=always -Wall -Winvalid-pch -std=gnu11 -march=native -O2 -pipe -fPIC -pthread -DHAVE_CONFIG_H -fcommon -fno-math-errno -D_FILE_OFFSET_BITS=64 -MD -MQ src/libsiril.a.p/core_siril_networking.c.o -MF src/libsiril.a.p/core_siril_networking.c.o.d -o src/libsiril.a.p/core_siril_networking.c.o -c ../siril-1.4.0/src/core/siril_networking.c
../siril-1.4.0/src/core/siril_networking.c:196:1: error: unknown type name ‘gboolean’
  196 | gboolean siril_compiled_with_networking() {
      | ^~~~~~~~
../siril-1.4.0/src/core/siril_networking.c: In function ‘siril_compiled_with_networking’:
../siril-1.4.0/src/core/siril_networking.c:197:16: error: ‘FALSE’ undeclared (first use in this function)
  197 |         return FALSE;
      |                ^~~~~
../siril-1.4.0/src/core/siril_networking.c:197:16: note: each undeclared identifier is reported only once for each function it appears in
../siril-1.4.0/src/core/siril_networking.c: At top level:
../siril-1.4.0/src/core/siril_networking.c:202:1: error: unknown type name ‘gboolean’
  202 | gboolean is_online() {
      | ^~~~~~~~
../siril-1.4.0/src/core/siril_networking.c: In function ‘is_online’:
../siril-1.4.0/src/core/siril_networking.c:203:53: error: ‘online_status’ undeclared (first use in this function)
  203 |         return (siril_compiled_with_networking() && online_status);
      |                                                     ^~~~~~~~~~~~~
../siril-1.4.0/src/core/siril_networking.c: At top level:
../siril-1.4.0/src/core/siril_networking.c:206:1: error: unknown type name ‘gboolean’
  206 | gboolean set_online_status(gboolean status) {
      | ^~~~~~~~
../siril-1.4.0/src/core/siril_networking.c:206:28: error: unknown type name ‘gboolean’
  206 | gboolean set_online_status(gboolean status) {
      |                            ^~~~~~~~

Additional information

In src/core/siril_networking.c some headers are included if HAVE_LIBCURL is defined. Outside this #if-clause the type gboolean is used, but not available due to some header not include (transitively) from inside the #if-clause.

Edited by Mario Haustein