From c9be438423059fb0e1439f4b1ab8e44cc4ded54a Mon Sep 17 00:00:00 2001 From: PUGAZHENDHI V <126157273+PugazhendhiVelu@users.noreply.github.com> Date: Thu, 13 Nov 2025 21:25:44 +0530 Subject: [PATCH] fix(period closing voucher): add title to error log (#50498) --- .../period_closing_voucher.py | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py index 210dbc5bbf..b416e5b839 100644 --- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py +++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py @@ -475,8 +475,15 @@ def process_gl_and_closing_entries(doc): frappe.db.set_value(doc.doctype, doc.name, "gle_processing_status", "Completed") except Exception as e: frappe.db.rollback() - frappe.log_error(e) - frappe.db.set_value(doc.doctype, doc.name, "gle_processing_status", "Failed") + frappe.log_error(title=_("Period Closing Voucher {0} GL Entry Processing Failed").format(doc.name)) + frappe.db.set_value( + doc.doctype, + doc.name, + { + "error_message": str(e), + "gle_processing_status": "Failed", + }, + ) def process_cancellation(voucher_type, voucher_no): @@ -488,8 +495,17 @@ def process_cancellation(voucher_type, voucher_no): frappe.db.set_value("Period Closing Voucher", voucher_no, "gle_processing_status", "Completed") except Exception as e: frappe.db.rollback() - frappe.log_error(e) - frappe.db.set_value("Period Closing Voucher", voucher_no, "gle_processing_status", "Failed") + frappe.log_error( + title=_("Period Closing Voucher {0} GL Entry Cancellation Failed").format(voucher_no) + ) + frappe.db.set_value( + voucher_type, + voucher_no, + { + "error_message": str(e), + "gle_processing_status": "Failed", + }, + ) def delete_closing_entries(voucher_no): -- GitLab