From 155e9357809d23d3b436366cd7107f87c0544c37 Mon Sep 17 00:00:00 2001 From: Antoine Maas Date: Mon, 22 Sep 2025 09:27:46 +0200 Subject: [PATCH] fix: fetch correct conversion when multiple uom are defined --- erpnext/venue/doctype/booking_credit/booking_credit.py | 4 ++-- .../doctype/booking_credit_usage/booking_credit_usage.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/venue/doctype/booking_credit/booking_credit.py b/erpnext/venue/doctype/booking_credit/booking_credit.py index cd88354123..a628e5c64e 100644 --- a/erpnext/venue/doctype/booking_credit/booking_credit.py +++ b/erpnext/venue/doctype/booking_credit/booking_credit.py @@ -305,9 +305,9 @@ def get_booking_credits_for_customer(customer, booking_credit_type=None, date=No return sum(frappe.db.get_all("Booking Credit", filters=filters, pluck="balance")) -def get_converted_qty(booking_credit_type, item): +def get_converted_qty(booking_credit_type, item, uom): return frappe.db.get_value( - "Booking Credit Type Conversions", {"parent": booking_credit_type, "item": item}, "credits" + "Booking Credit Type Conversions", {"parent": booking_credit_type, "item": item, "uom": uom}, "credits" ) diff --git a/erpnext/venue/doctype/booking_credit_usage/booking_credit_usage.py b/erpnext/venue/doctype/booking_credit_usage/booking_credit_usage.py index 7b92102e6f..cd54749643 100644 --- a/erpnext/venue/doctype/booking_credit_usage/booking_credit_usage.py +++ b/erpnext/venue/doctype/booking_credit_usage/booking_credit_usage.py @@ -61,7 +61,7 @@ def add_booking_credit_usage(doc, method): bct = get_booking_credit_types_for_item(doc.item, doc.uom) for bc in bct: credits = get_booking_credits_for_customer(doc.party_name, bc) - quantity = get_converted_qty(bc, doc.item) + quantity = get_converted_qty(bc, doc.item, doc.uom) if credits and credits >= quantity: usage = frappe.get_doc( { -- GitLab