From 08dfe325b9bc39e8fb0ef0f7afe519caf6d07abf Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Fri, 27 Dec 2024 12:57:52 +0530 Subject: [PATCH] fix: ignore inventory dimension for SABB and Pick List (#44933) --- .../inventory_dimension/inventory_dimension.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/inventory_dimension/inventory_dimension.py b/erpnext/stock/doctype/inventory_dimension/inventory_dimension.py index 4f8a166932..da31a6f209 100644 --- a/erpnext/stock/doctype/inventory_dimension/inventory_dimension.py +++ b/erpnext/stock/doctype/inventory_dimension/inventory_dimension.py @@ -239,8 +239,22 @@ class InventoryDimension(Document): dimension_field["fieldname"] = self.target_fieldname custom_fields["Stock Ledger Entry"] = dimension_field + filter_custom_fields = {} + ignore_doctypes = ["Serial and Batch Bundle", "Serial and Batch Entry", "Pick List Item"] + if custom_fields: - create_custom_fields(custom_fields) + for doctype, fields in custom_fields.items(): + if doctype in ignore_doctypes: + continue + + if isinstance(fields, dict): + fields = [fields] + + for field in fields: + if not field_exists(doctype, field["fieldname"]): + filter_custom_fields.setdefault(doctype, []).append(field) + + create_custom_fields(filter_custom_fields) def add_transfer_field(self, doctype, dimension_fields): if doctype not in [ -- GitLab