From e0ad17ff3ffb3acb92c9466080520c2c3c96938a Mon Sep 17 00:00:00 2001 From: ljain112 Date: Tue, 30 Jul 2024 17:49:56 +0530 Subject: [PATCH] fix: min height for rows in sales funnel --- erpnext/selling/page/sales_funnel/sales_funnel.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/erpnext/selling/page/sales_funnel/sales_funnel.js b/erpnext/selling/page/sales_funnel/sales_funnel.js index 017f971ae9..647b2904d1 100644 --- a/erpnext/selling/page/sales_funnel/sales_funnel.js +++ b/erpnext/selling/page/sales_funnel/sales_funnel.js @@ -178,6 +178,9 @@ erpnext.SalesFunnel = class SalesFunnel { this.options.width = $(this.elements.funnel_wrapper).width() * 2.0 / 3.0; this.options.height = (Math.sqrt(3) * this.options.width) / 2.0; + const min_height = (this.options.height * 0.1) / this.options.data.length; + const height = this.options.height * 0.9; + // calculate total weightage // as height decreases, area decreases by the square of the reduction // hence, compensating by squaring the index value @@ -185,8 +188,8 @@ erpnext.SalesFunnel = class SalesFunnel { function(prev, curr, i) { return prev + Math.pow(i+1, 2) * curr.value; }, 0.0); // calculate height for each data - $.each(this.options.data, function(i, d) { - d.height = me.options.height * d.value * Math.pow(i+1, 2) / me.options.total_weightage; + $.each(this.options.data, function (i, d) { + d.height = (height * d.value * Math.pow(i + 1, 2)) / me.options.total_weightage + min_height; }); this.elements.canvas = $('') -- GitLab