From 34449f5abc9282327824b9d661c4f5208bd43567 Mon Sep 17 00:00:00 2001 From: tonspar <121026420+tonspar@users.noreply.github.com> Date: Fri, 28 Jun 2024 13:47:51 +0200 Subject: [PATCH] fix: Correct dunnings resolving after PE submit (#41792) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> --- erpnext/accounts/doctype/dunning/dunning.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/dunning/dunning.py b/erpnext/accounts/doctype/dunning/dunning.py index 36c517a478..b466e02026 100644 --- a/erpnext/accounts/doctype/dunning/dunning.py +++ b/erpnext/accounts/doctype/dunning/dunning.py @@ -193,10 +193,13 @@ def resolve_dunning(doc, state): outstanding_ps = frappe.get_value( "Payment Schedule", overdue_payment.payment_schedule, "outstanding" ) - resolve = False if (outstanding_ps > 0 and outstanding_inv > 0) else True + resolve = resolve and (False if (outstanding_ps > 0 and outstanding_inv > 0) else True) - dunning.status = "Resolved" if resolve else "Unresolved" - dunning.save() + new_status = "Resolved" if resolve else "Unresolved" + + if dunning.status != new_status: + dunning.status = new_status + dunning.save() def get_linked_dunnings_as_per_state(sales_invoice, state): -- GitLab