From 818837253baec65704b450883a2241279c6b11af Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Wed, 27 Mar 2024 14:28:37 +0530 Subject: [PATCH] fix: typeerror on Purchase Order form UI --- .../doctype/purchase_order/purchase_order.js | 32 ++++++++++++++----- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/erpnext/buying/doctype/purchase_order/purchase_order.js b/erpnext/buying/doctype/purchase_order/purchase_order.js index 5bf79474fb..c4177a4a85 100644 --- a/erpnext/buying/doctype/purchase_order/purchase_order.js +++ b/erpnext/buying/doctype/purchase_order/purchase_order.js @@ -311,22 +311,38 @@ erpnext.buying.PurchaseOrderController = class PurchaseOrderController extends e } if(doc.status != "Closed") { if (doc.status != "On Hold") { - if(flt(doc.per_received, 2) < 100 && allow_receipt) { - cur_frm.add_custom_button(__('Purchase Receipt'), this.make_purchase_receipt, __('Create')); + if (flt(doc.per_received, 2) < 100 && allow_receipt) { + this.frm.add_custom_button( + __("Purchase Receipt"), + () => { + me.make_purchase_receipt(); + }, + __("Create") + ); if (doc.is_subcontracted) { if (doc.is_old_subcontracting_flow) { if (me.has_unsupplied_items()) { cur_frm.add_custom_button(__('Material to Supplier'), function() { me.make_stock_entry(); }, __("Transfer")); } - } - else { - cur_frm.add_custom_button(__('Subcontracting Order'), this.make_subcontracting_order, __('Create')); + } else { + this.frm.add_custom_button( + __("Subcontracting Order"), + () => { + me.make_subcontracting_order(); + }, + __("Create") + ); } } } - if(flt(doc.per_billed, 2) < 100) - cur_frm.add_custom_button(__('Purchase Invoice'), - this.make_purchase_invoice, __('Create')); + if (flt(doc.per_billed, 2) < 100) + this.frm.add_custom_button( + __("Purchase Invoice"), + () => { + me.make_purchase_invoice(); + }, + __("Create") + ); if(flt(doc.per_billed, 2) < 100 && doc.status != "Delivered") { this.frm.add_custom_button( -- GitLab