From c3cbc40cbf9b20b3e56e702cbed6a4f98589d384 Mon Sep 17 00:00:00 2001 From: Genar Trias Ortiz Date: Wed, 13 Nov 2019 02:01:25 +0100 Subject: [PATCH 1/8] lots of ui improvements --- .storybook/config.js | 1 + .storybook/webpack.config.js | 7 ++- config/cssRules.js | 1 - package.json | 3 + src/components/ArtistView/index.tsx | 12 ++-- src/components/Buttons/SearchButton.tsx | 1 - src/components/Sidebar/SidebarContents.tsx | 2 +- src/components/SongView/SongView.tsx | 35 ++++++----- .../Topbar/SearchInput/index.stories.tsx | 21 +++++++ src/components/Topbar/SearchInput/index.tsx | 59 ++++++++++++++++++ src/components/Topbar/Topbar.spec.tsx | 39 ------------ src/components/Topbar/Topbar.styles.ts | 24 ------- src/components/Topbar/Topbar.tsx | 62 ++++++++----------- src/components/common/Icon/index.tsx | 27 ++++++++ src/components/common/Tag/index.styles.tsx | 18 ------ src/components/common/Tag/index.tsx | 2 +- src/styles/App.scss | 3 - src/styles/cards.scss | 7 --- src/styles/form.scss | 3 - src/styles/playlists.scss | 2 - src/styles/searchBar.scss | 36 ----------- src/styles/settings.scss | 4 -- yarn.lock | 27 ++++++++ 23 files changed, 197 insertions(+), 199 deletions(-) create mode 100644 src/components/Topbar/SearchInput/index.stories.tsx create mode 100644 src/components/Topbar/SearchInput/index.tsx delete mode 100644 src/components/Topbar/Topbar.spec.tsx delete mode 100644 src/components/Topbar/Topbar.styles.ts create mode 100644 src/components/common/Icon/index.tsx delete mode 100644 src/components/common/Tag/index.styles.tsx delete mode 100644 src/styles/cards.scss delete mode 100644 src/styles/form.scss delete mode 100644 src/styles/searchBar.scss diff --git a/.storybook/config.js b/.storybook/config.js index 563020c2..4394bff8 100644 --- a/.storybook/config.js +++ b/.storybook/config.js @@ -1,4 +1,5 @@ import { configure } from '@storybook/react' import '../src/App.css' +import "font-awesome/css/font-awesome.min.css" configure(require.context('../src', true, /\.stories\.tsx/), module) diff --git a/.storybook/webpack.config.js b/.storybook/webpack.config.js index d6794e15..b5aa7b69 100644 --- a/.storybook/webpack.config.js +++ b/.storybook/webpack.config.js @@ -25,7 +25,12 @@ module.exports = async ({ config, mode }) => { ...config, module: { ...config.module, - rules: [typescriptRules, ...cssRules] + rules: [typescriptRules, ...cssRules, + { + test: /\.(png|woff|woff2|eot|ttf|svg)$/, + loaders: ['file-loader'] + } + ] } } } diff --git a/config/cssRules.js b/config/cssRules.js index 625ef748..7fed30e6 100644 --- a/config/cssRules.js +++ b/config/cssRules.js @@ -5,7 +5,6 @@ module.exports = [ // SASS support { test: /\.scss$/, - include: paths.appSrc, loaders: ["style-loader", "css-loader", "sass-loader"] }, // "postcss" loader applies autoprefixer to our CSS. diff --git a/package.json b/package.json index a4c4bb6a..d2af4c5a 100644 --- a/package.json +++ b/package.json @@ -6,6 +6,9 @@ "@babel/core": "^7.0.0", "@babel/preset-typescript": "^7.6.0", "@babel/runtime-corejs2": "^7.0.0", + "@fortawesome/fontawesome-svg-core": "^1.2.25", + "@fortawesome/free-solid-svg-icons": "^5.11.2", + "@fortawesome/react-fontawesome": "^0.1.7", "@sindresorhus/slugify": "^0.9.0", "@storybook/addon-knobs": "^5.2.5", "@storybook/react": "^5.2.4", diff --git a/src/components/ArtistView/index.tsx b/src/components/ArtistView/index.tsx index a8509c23..7a407111 100644 --- a/src/components/ArtistView/index.tsx +++ b/src/components/ArtistView/index.tsx @@ -100,16 +100,16 @@ export default class ArtistView extends React.Component { } return ( -
+
-

{ artist.name }

+

{ artist.name }

    { albumsByArtist.map((albumId) => { return ( -
  • -

    +
  • +
    { size='thumbnail' albumName={'N/A'} /> +
    +

    { albums[albumId].name }

    -
    +
    { extractSongs(albums[albumId]) }
  • diff --git a/src/components/Buttons/SearchButton.tsx b/src/components/Buttons/SearchButton.tsx index 260ae29a..516defc9 100644 --- a/src/components/Buttons/SearchButton.tsx +++ b/src/components/Buttons/SearchButton.tsx @@ -22,7 +22,6 @@ const SearchButton = ({dispatch, searchToggled}: Props) => { return (