[BUG] Light theme is broken in some areas #5

Open
opened 2024-05-12 21:56:43 +02:00 by freeplay · 6 comments

Description

See screenshots

Screenshots

screenshots attached

Forgejo Version

8.0.0-devgay+gitea-1.22.0

Can you reproduce the bug on Forgejo Next?

Yes

Browser Version

Firefox 125.0.3 (64-bit)

Operating System

Fedora 40

### Description See screenshots ### Screenshots screenshots attached ### Forgejo Version 8.0.0-devgay+gitea-1.22.0 ### Can you reproduce the bug on Forgejo Next? Yes ### Browser Version Firefox 125.0.3 (64-bit) ### Operating System Fedora 40
Owner

Will look into this as soon as I get a chance!

Will look into this as soon as I get a chance!
Author

Another minor thing in dark mode is that horizontal rules aren't visible (they use the same color as the background)
image

Another minor thing in dark mode is that horizontal rules aren't visible (they use the same color as the background) ![image](/attachments/c00eda40-052c-4912-89d7-77e51d9ff224)
Owner

the areas mentioned here are fixed (besides the hr one)
I’ll leave the issue open though cause the light theme is far from decent and obviously needs tonnes more work. but fixing basic contrast issues and broken parts like that are worth getting ahead to fix

the areas mentioned here are fixed (besides the hr one) I’ll leave the issue open though cause the light theme is far from decent and obviously needs tonnes more work. but fixing basic contrast issues and broken parts like that are worth getting ahead to fix

I've found another light theme issue: the "commit signed by…" text has bad contrast.
Screenshot of white text on a light blue background saying "Commit signed by git.gay" with a GPG key on the other side.

I've found another light theme issue: the "commit signed by…" text has bad contrast. ![Screenshot of white text on a light blue background saying "Commit signed by git.gay" with a GPG key on the other side.](/attachments/8c8a6a78-0193-4171-ad67-544558df9b3e)

When you add a GPG or SSH key, the text indicating the vertification has not enough contrast. Is like the second screenshot shared in this issues.

When you add a GPG or SSH key, the text indicating the vertification has not enough contrast. Is like the second screenshot shared in this issues.
Contributor

This also happens in user settings.
image

This also happens in [user settings](https://git.gay/user/settings). ![image](/attachments/1f199d91-ada5-43eb-9552-83e735863b90)
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
gitgay/forgejo#5
No description provided.