Panic when one of the files to merge contains conflicts in diff2 format #520
Labels
No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: mergiraf/mergiraf#520
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If
mergiraf solve
is invoked on files where one of the revisions already contains conflicts represented in diff2 format (without the base part), then this leads to a panic:Even though such cases should only happen when the user has committed a file with conflicts into git (which is bad), we should make sure that:
A reproducing test case is attached (taken from https://github.com/qiskit/qiskit-terra)
If the leftover conflict is part of a comment block, the source file can be parsed and this can also trigger another panic somewhere else:
Attached is another minimized test case.