mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 51 Pull requests 7 Releases 19 Activity Actions

chore: Update testing helpers to support test cases without extensions #486

Merged
wetneb merged 1 commit from wetneb/fix_helpers_again into main 2025-07-10 08:48:12 +02:00 AGit
Conversation 6 Commits 1 Files changed 4 +20 -23
wetneb commented 2025-07-09 10:50:07 +02:00
Owner
Copy link

Sorry that the previous update was sloppy, I forgot to update the
remaining scripts…

Sorry that the previous update was sloppy, I forgot to update the remaining scripts…
chore: Update testing helpers to support test cases without extensions
All checks were successful
/ test (pull_request) Successful in 36s
Details
7cb69e71e3 
Sorry that the previous update was sloppy, I forgot to update the
remaining scripts…
ada4a commented 2025-07-09 10:57:42 +02:00
Owner
Copy link

No need to apologize. My review was evidently just as sloppy, given that I didn't notice this^^

I wonder if it would make sense to introduce a minimum time window between approval and merging – I often notice these kinds of oversights after letting the PR sit in my head a little. Is that something that Codeberg supports?..

No need to apologize. My review was evidently just as sloppy, given that I didn't notice this^^ I wonder if it would make sense to introduce a minimum time window between approval and merging – I often notice these kinds of oversights after letting the PR sit in my head a little. Is that something that Codeberg supports?..
wetneb commented 2025-07-09 10:59:02 +02:00
Author
Owner
Copy link

Is that something that Codeberg supports?..

Not that I know of, but we can have it as a social convention :)

> Is that something that Codeberg supports?.. Not that I know of, but we can have it as a social convention :)
ada4a commented 2025-07-09 11:02:27 +02:00
Owner
Copy link

That works as well!

That works as well!
wetneb commented 2025-07-09 21:51:46 +02:00
Author
Owner
Copy link

So can you approve it? :-D

So can you approve it? :-D
ada4a approved these changes 2025-07-09 21:56:45 +02:00
ada4a commented 2025-07-09 21:59:44 +02:00
Owner
Copy link

You could merge it as well.. this PR is straightforward enough

You could merge it as well.. this PR is straightforward enough
wetneb merged commit da718b0abd into main 2025-07-10 08:48:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ada4a
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#486
No description provided.
Delete branch "wetneb/fix_helpers_again"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?