mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 51 Pull requests 7 Releases 19 Activity Actions

perf: avoid calling Matching::add in a loop #329

Merged
ada4a merged 6 commits from ada4a/mergiraf:matching_avoid_add into main 2025-04-17 16:21:07 +02:00
Conversation 2 Commits 6 Files changed 4 +45 -19
ada4a commented 2025-04-17 14:50:01 +02:00
Owner
Copy link

It calls HashMap::insert internally. One should avoid calling that
method in a loop, and instead pass the iterator into HashMap::extend,
so that the map can (hopefully) preallocate enough space.

This PR introduces Matching::extend which does exactly that.

The other thing Matching::add does is call Matching::remove, which I
couldn't find a way to "serialize", so it's still called in the loop.
That can be an area for further improvement.

It calls `HashMap::insert` internally. One should avoid calling that method in a loop, and instead pass the iterator into `HashMap::extend`, so that the map can (hopefully) preallocate enough space. This PR introduces `Matching::extend` which does exactly that. The other thing `Matching::add` does is call `Matching::remove`, which I couldn't find a way to "serialize", so it's still called in the loop. That can be an area for further improvement.
ada4a changed title from perf(Matching): avoid caling Self::add in a loop to perf: avoid caling Matching::add in a loop 2025-04-17 14:50:42 +02:00
wetneb approved these changes 2025-04-17 15:38:43 +02:00
ada4a changed title from perf: avoid caling Matching::add in a loop to perf: avoid calling Matching::add in a loop 2025-04-17 15:48:04 +02:00
ada4a commented 2025-04-17 16:11:59 +02:00
Author
Owner
Copy link

rebased onto main

rebased onto main
ada4a force-pushed matching_avoid_add from 4ad971eccc to 803e3fab50 2025-04-17 16:12:02 +02:00 Compare
ada4a merged commit ef4e2bb13d into main 2025-04-17 16:21:07 +02:00
ada4a deleted branch matching_avoid_add 2025-04-17 16:21:09 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
wetneb
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#329
No description provided.
Delete branch "ada4a/mergiraf:matching_avoid_add"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?