Mark all strings as atomic

wetneb commented

2025-04-16 09:40:44 +02:00

Owner

The compact output was somewhat more surprising:
# ExpectedCompact.hcl
variable "foo" {
  description = "
<<<<<<< LEFT
hello left
||||||| BASE
hello world
=======
hello right
>>>>>>> RIGHT
"
}
I would've expect the quotes to stay around the strings. But an identical test in Rust has the same behaviour, so I guess it's fine.

This can be solved by marking string nodes as being atomic, to prevent them from being analyzed into "opening quote, contents, closing quote".

mark strings as atomics for all existing supported languages
update the documentation to recommend marking them as atomic in new languages too

Quoting @ada4a in https://codeberg.org/mergiraf/mergiraf/pulls/210: > The compact output was somewhat more surprising: > ```hcl > # ExpectedCompact.hcl > variable "foo" { > description = " > <<<<<<< LEFT > hello left > ||||||| BASE > hello world > ======= > hello right > >>>>>>> RIGHT > " > } > ``` > I would've expect the quotes to stay around the strings. But an identical test in Rust has the same behaviour, so I guess it's fine. This can be solved by marking string nodes as being atomic, to prevent them from being analyzed into "opening quote, contents, closing quote". - [ ] mark strings as atomics for all existing supported languages - [ ] update the documentation to recommend marking them as atomic in new languages too

wetneb commented

2025-05-11 13:09:39 +02:00

Author

Owner

We need to consider the implications for matching carefully, since marking strings as atomic will tend to decrease the depth of some trees, making matching more conservative.

wetneb referenced this issue

2025-05-12 08:55:44 +02:00

fix: Handling of quoted strings in YAML #380

wetneb commented

2025-05-12 09:04:50 +02:00

Author

Owner

Strings not being marked as atomic is the source of bugs when the string contents are not exposed as public nodes by the grammar, which happens surprisingly often (in YAML #380, but also earlier in Go).

wetneb referenced this issue from a commit

2025-05-12 13:48:51 +02:00

fix: Handling of quoted strings in YAML (#380)

wetneb referenced this issue

2025-07-09 10:54:51 +02:00

Broader test suite for benchmarks #485

Rows
Columns

Mark all strings as atomic #325