mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 50 Pull requests 6 Releases 19 Activity Actions

fix: Don't match nodes of different types #367

Merged
wetneb merged 2 commits from wetneb/mergiraf:assert_grammar_names into main 2025-05-06 04:09:44 +02:00
Conversation 1 Commits 2 Files changed 3 +55 -3
wetneb commented 2025-05-05 21:41:09 +02:00
Owner
Copy link

The pre-matching of nodes based on merged chunks in line-based merges didn't check that the nodes are of the same type.
This made it possible in certain languages to match a list with its first element, for instance (see the test case).
I haven't encountered a merge scenario where this leads to an undesirable output, but discovered this inconsistency while working on something else.

The pre-matching of nodes based on merged chunks in line-based merges didn't check that the nodes are of the same type. This made it possible in certain languages to match a list with its first element, for instance (see the test case). I haven't encountered a merge scenario where this leads to an undesirable output, but discovered this inconsistency while working on something else.
Also index nodes by grammar_name
All checks were successful
/ test (pull_request) Successful in 58s
Details
3d87eed54d
ada4a approved these changes 2025-05-05 23:17:14 +02:00
wetneb merged commit 2a2c954f91 into main 2025-05-06 04:09:44 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ada4a
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#367
No description provided.
Delete branch "wetneb/mergiraf:assert_grammar_names"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?