fix: Make Python "import from" statements commutative #248
No reviewers
Labels
No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: mergiraf/mergiraf#248
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "wetneb/mergiraf:python_import_from"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
So far we were able to reorder statements of the form
import foobut notfrom foo import bar. This fixes it.@ -0,0 +1,17 @@from .....pagination import SyncCursorPage, AsyncCursorPageIt's kind of hard to tell from a glance what gets merged with what -- maybe it could be helpful to minimize the example a little and use shorter names?
Good point! I did think about it, was just too lazy to act on it ^^
Much clearer now, thank you:)
Oh and I also think this could be
featinstead offix, since we add more functionality -- but I guess that's not too importantIt was reported to me as a bug, and it was also my expectation that such a case worked already, so that's why I think of it as a fix, but yeah, the difference is sometimes not clear cut ^^