mergiraf/mergiraf
mergiraf/mergiraf
9
213
Fork 45
Code Issues 51 Pull requests 7 Releases 19 Activity Actions

Support displaying both Commutative and Signature for the same nodes #126

Merged
wetneb merged 1 commit from mianm/mergiraf:commutative-with-signatures into main 2025-01-04 21:49:56 +01:00
Conversation 1 Commits 1 Files changed 1 +9 -3
mianm commented 2025-01-04 06:35:41 +01:00
Contributor
Copy link

Fixes #124

Hopefully this is right. I'm not sure if it would be preferred to still not hit these code paths if the first branch is hit (the "num_children == 0 ..." one), but this does seem to work in my testing at least.

Fixes #124 Hopefully this is right. I'm not sure if it would be preferred to still not hit these code paths if the first branch is hit (the "num_children == 0 ..." one), but this does seem to work in my testing at least.
Support displaying both Commutative and Signature for the same nodes
All checks were successful
/ rustfmt (pull_request) Successful in 20s
Details
/ clippy (pull_request) Successful in 42s
Details
/ test (pull_request) Successful in 35s
Details
34d4dc744a
wetneb approved these changes 2025-01-04 21:49:38 +01:00
wetneb left a comment
Owner
Copy link

Thanks a lot!

Thanks a lot!
wetneb merged commit f9e31f4e0f into main 2025-01-04 21:49:56 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
wetneb
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind
Bad merge
Examples where the merging algorithm doesn't work as well as it should

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
New language

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind
Bad merge
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
New language
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: mergiraf/mergiraf#126
No description provided.
Delete branch "mianm/mergiraf:commutative-with-signatures"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?