| commit | 1206a315a3404fa320206e3f38f5a0e1d533fa7c | [log] [tgz] |
|---|---|---|
| author | Michael Thiessen <mthiesse@chromium.org> | Thu Oct 09 14:56:50 2025 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Oct 09 14:59:37 2025 |
| tree | ee61f5af8ae411ddb9305b63b0662ea1eb866a4a | |
| parent | 8451e406403fbc4a3ef1e5d57b059970ebea678d [diff] |
Ensure native BrowserTests tear down activity properly Our historical call to Activity#finish in NativeTest.java didn't actually do anything, because we immediately crash during activity teardown because browsertests tear down everything including features and PostTask. This means we need to finish the Activity before browser test teardown, and fix a few tests that were unintentionally relying on the browser not being torn down. This is mainly needed for PRE_ tests which often rely on a clean browser teardown to save state for the following test. Bug: 40200835 Change-Id: Ifcfd024466ab98899fd418ee3d218180ac6243dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7003215 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1527520} NOKEYCHECK=True GitOrigin-RevId: a229d33e80ffa267211146c4abf62ee3a34fd5e6
//build contains:
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing, select //third_party subdirectories), but new dependencies tend to break these other projects, and so should be avoided.
Changes to //build should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.
//build/config - Common templates via .gni files.//build/toolchain - GN toolchain definitions.Other .py files - Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.Files referenced by //.gn:
//build/BUILDCONFIG.gn - Included by all BUILD.gn files.//build/secondary - An overlay for BUILD.gn files. Enables adding BUILD.gn to directories that live in sub-repositories.//build_overrides - Refer to //build_overrides/README.md.