[go: up one dir, main page]

Closed Bug 1934525 Opened 1 year ago Closed 1 year ago

Implement new path data API

Categories

(Core :: SVG, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 3 obsolete files)

Attached file testcase (edited to omit setPathData) (obsolete) β€”
Attached patch WIP (obsolete) β€” β€” Splinter Review
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Attachment #9441559 - Attachment is obsolete: true

Once this lands, it should be documented at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features. Reading the attached patch, the related pref is dom.svg.pathSegment.enabled and enabled by default in Nightly builds.

Sebastian

Keywords: dev-doc-needed
Blocks: 1903594
Blocks: 1745060
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50030 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]: yes
[Suggested wording]: Firefox has an implementation of the new SVG 2 path API. Currently enabled on nightly only but there will be a pref dom.svg.pathSegment.enabled that you can enable from Firefox 136.
[Links (documentation, blog post, etc)]:
https://svgwg.org/specs/paths/#DOMInterfaces
https://github.com/jarek-foksa/path-data-polyfill (polyfill for browsers that don't have a native implementation)
https://stackoverflow.com/questions/34919405

relnote-firefox: --- → ?
Upstream PR merged by moz-wptsync-bot

Added to the Fx136 nightly release notes, please allow 30 minutes for the site to update.

Blocks: 1945312

I am probably missing something here, but when I test the example above I am just getting the error: SVGPathSegment is not defined.
I have tested this in:

  • Firefox Nightly 137.0a1
  • Firefox Beta 136.0 with the flag dom.svg.pathSegment.enabled set to true

removing nightly+ relnote flag since this will be in the 137 release notes via bug 1945312

Attachment #9440988 - Attachment is obsolete: true

(In reply to Dave Letorey from comment #18)

I am probably missing something here, but when I test the example above I am just getting the error: SVGPathSegment is not defined.
I have tested this in:

  • Firefox Nightly 137.0a1
  • Firefox Beta 136.0 with the flag dom.svg.pathSegment.enabled set to true

I've replaced the testcase. The previous one was what I started with for development but in the end I discovered it isn't actually valid as the SVGPathSegment type doesn't have a javascript interface according to https://svgwg.org/specs/paths/#DOMInterfaces

Regressions: 1954044
Regressions: 1967497
No longer regressions: 1967497
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: