#3368 immigrant queue weird behaviour
freecol trunk rev 17cb6fec7
Occasionally I noticed that all 3 available immigrants in europe recruit queue were of the same type. Looking inside the samegave showed the first slot in the queue had a count of 3 or higher .
I have now been able to pinpoint an occurrence of this .
In the attached e81d7bb1_Dutch_1498.fsg immigrant queue is
<recruit role="model.role.default" number="1" id="model.unit.indenturedServant"/>
<recruit role="model.role.default" number="1" id="model.unit.indenturedServant"/>
<recruit role="model.role.default" number="1" id="model.unit.pettyCriminal"/>
On the next turn a petty criminal has decided to immigrate .
I expect to see indentured servant in first and second slot, and a new random unittype in 3rd slot .
The e81d7bb1_Dutch_1499 test.fsg however shows
<recruit number="2" role="model.role.default" id="model.unit.indenturedServant"/>
<recruit number="1" role="model.role.default" id="model.unit.pettyCriminal"/>
<recruit number="1" role="model.role.default" id="model.unit.masterBlacksmith"/>
It appears 1st and 2nd slot are grouped together and then two random units are added.
This happens rather often and I have seen number counts as high as 8 for first slot .
This can lead to people thinking freecol is broken because they don't see different units in immigrant queue
Is this behaviour of europe immigrant queue intentional ?
If yes, wouldn't it be better to allow players to choose from either of the top 3 slots, regardless of the number count ?