[go: up one dir, main page]

Menu

#12 Redundant breaks

1.0
closed
None
2019-11-08
2019-11-07
No

redundant breaks (multiple break boundaries of the same type at the same CTokenNo position) should also be ignored by the indexer anywhere they occur (–> "no empty sentences"), because that messes things up at query-time. They can be specified in the tab-import input, but should not cause duplicate breaks to be inserted into the physical index.

Discussion

  • Alexey Sokirko

    Alexey Sokirko - 2019-11-07

    Can I do it for all input index formats? I will try to insert it inside the core indexing code. I hope, it is safe.

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08

    HitBorders.cpp still contains real tabs. I was prohibited to use Clion autoformat, so leave as it is.

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08
    • status: open --> closed
     
  • Bryan Jurish

    Bryan Jurish - 2019-11-08

    argh; it looks as if my TAB-expansion commit (r1320) only actually caught *.h files after all - my error, sorry. go ahead and use Clion autoformat if you need too; I'll do the TAB-expansion on *.cpp files and re-reformatting during the next merge.

    Please do implement this for all ddc_index inpout formats if possible. Re-opening.

     
  • Bryan Jurish

    Bryan Jurish - 2019-11-08
    • status: closed --> open
    • assigned_to: Bryan Jurish --> Alexey Sokirko
     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08

    I think I've finished this ticket

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08
    • status: open --> closed
     

Log in to post a comment.