[go: up one dir, main page]

Menu

#4 %%$DDC:meta.n

1.0
closed
None
2019-11-08
2019-11-07
No

r1256 Concordance.cpp: please keep "%%$DDC:meta.n_=%u" in tab-dump output format

Discussion

  • Alexey Sokirko

    Alexey Sokirko - 2019-11-07

    It should be already ignored, since there is
    else if (field == META_N) {
    // nothing to store
    }
    I added this case to tests.

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-07
    • status: open --> closed
     
  • Bryan Jurish

    Bryan Jurish - 2019-11-07

    yes, it was ignored by ddc_index, but I believe r1256 causedddc_dump to stop emitting it.

     
  • Bryan Jurish

    Bryan Jurish - 2019-11-08
    • status: closed --> open
    • assigned_to: Bryan Jurish --> Alexey Sokirko
     
  • Bryan Jurish

    Bryan Jurish - 2019-11-08

    re-opened & re-assigned

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08

    Right now there is no "if" before fprintf(f, "%s:meta.n_=%u\n", cmt, (uint) FileNo);

    void CConcordance::DumpFileIndexTabs(DWORD FileNo, FILE f) const {
    //-- dump: token range
    const char
    cmt = "%%$DDC";
    CTokenNo tok_min = FileNo == 0 ? 0 : GetFileBreaks()[FileNo - 1];
    CTokenNo tok_max = GetFileBreaks()[FileNo];

    fprintf(f, "%s:tokid.begin=%u\n", cmt, (uint) tok_min);
    fprintf(f, "%s:tokid.end=%u\n", cmt, (uint) tok_max);
    fprintf(f, "%s:meta.n_=%u\n", cmt, (uint) FileNo);
    
     

    Last edit: Alexey Sokirko 2019-11-08
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08

    In cmake tests output tab formatted files starts as follows:
    %%$DDC:tokid.begin=13
    %%$DDC:tokid.end=26
    %%$DDC:meta.n_=1
    %%$DDC:meta.file_=./a.xml

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08

    So please reopen, if you see problems in delwin branch.

     
  • Alexey Sokirko

    Alexey Sokirko - 2019-11-08
    • status: open --> closed
     

Log in to post a comment.