[Colossus-tracker] [ colossus-Bugs-3516697 ] Coward2 Exception

Bugs item #3516697, was opened at 2012-04-10 18:28
Message generated for change (Comment added) made by sewerstarfish
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101939&aid=3516697&group_id=1939

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
>Priority: 1
Private: No
Submitted By: Patrick Bauer (sewerstarfish)
Assigned to: Clemens Katzer (cleka)
Summary: Coward2 Exception

Initial Comment:
The following was recorded while playing Colossus 0.12.0 Build 2011-02-15 19:52:59 by katzer from revision 4995 java version 1.6.0_24 in Windows 7

Woooah! An exception was caught while processing from client Coward2 the input line:
    === doBattleMove ~ 313 ~ B3 ===

Stack trace:
java.util.ConcurrentModificationException
	at java.util.AbstractList$Itr.checkForComodification(Unknown Source)
	at java.util.AbstractList$Itr.next(Unknown Source)
	at net.sf.colossus.server.Server.allTellBattleMove(Server.java:2102)
	at net.sf.colossus.server.BattleServerSide.moveCritterToHexAndInformClients(BattleServerSide.java:1102)
	at net.sf.colossus.server.BattleServerSide.doMove(BattleServerSide.java:1080)
	at net.sf.colossus.server.Server.doBattleMove(Server.java:2088)
	at net.sf.colossus.server.ClientHandler.callMethod(ClientHandler.java:513)
	at net.sf.colossus.server.ClientHandler.doCallMethodInTryBlock(ClientHandler.java:356)
	at net.sf.colossus.server.ClientHandler.processInput(ClientHandler.java:159)
	at net.sf.colossus.server.Server.handleSelectedKeys(Server.java:528)
	at net.sf.colossus.server.Server.waitOnSelector(Server.java:399)
	at net.sf.colossus.server.Server.run(Server.java:227)


Game might be unstable or hang from now on...

----------------------------------------------------------------------

>Comment By: Patrick Bauer (sewerstarfish)
Date: 2012-04-11 13:13

Message:
1) I'm lazy
2) I believe it was while quitting .
3) Sorry not on Linux

You should probably just ignore it.



----------------------------------------------------------------------

Comment By: Patrick Bauer (sewerstarfish)
Date: 2012-04-11 13:13

Message:

This bug tracker item has been closed, since it is very old and probably
not relevant any more.

Colossus has been changed so much internally, that the problem situation
most likely does not exist any more; but even if it would still exist, it
would be hard to fix with the given info, because attached saved games
don't work nowadays any more.

Should someone again come over this bug situation, now a new bug tracker
item should be created with a recent Colossus version.


----------------------------------------------------------------------

Comment By: Clemens Katzer (cleka)
Date: 2012-04-10 21:12

Message:
Hi!

1) You seem to use a rather old release of Colossus. May I ask why?

2) Can you withcertaintly say whether this was "somewhere during the game"
or "possibly when ending the game" ? I've see similar error messages
happening when one does quit or start new game from File menu, while game
is still ongoing full speed (e.g. only AIs left). 
[technically, the Event Dispatcher Thread (executing the "File-Quit" menu
item) starts the cleanup, which removes clients from a list; but in same
time the "main game thread" is still processing input from a client, in
this case involving iterating over the list of all clients to tell them the
battle results. So while it's iterating, it notices that suddenly "someone
else" has removed an item from the list.]

3) if you're on Linux, could you check whether there's a log file like so:

[katzer@dhcppc2 ws]$ ll /tmp | grep Colossus
-rw-r--r--. 1 katzer  everybody   50237 Apr 10 21:41 Colossus0.log
-rw-r--r--. 1 katzer  everybody    1445 Apr 10 20:18 Colossus1.log
-rw-r--r--. 1 katzer  everybody    1445 Apr 10 20:17 Colossus2.log
[katzer@dhcppc2 ws]$ 

The one with number 0 is always newest. If you haven't played "much" since
then, the log file from that game might still exist.


BR,
Clemens


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=101939&aid=3516697&group_id=1939