torcs-devel Mailing List for TORCS - The Open Racing Car Simulator

Hi Mart

>>> I have attached a patch which resolves this issue(s).
>> Hmm, if nobody uses it, why not just remove it?
> 
> That is of course also a solution. I don't see directly what a bot can do with 
> this information. Torcs does compile correctly without that field.
> 
> I use it for the track records, but because the race has ended when I look to 
> those records, there are other ways to find out the category of the car.

Ok, fair enough, I applied it. Thank you for the report.

Bye, Bernhard.

-- 

Visit my homepage http://www.berniw.org
Official TORCS racing: The TORCS Racing Board, http://www.berniw.org/trb

Hi Mart

>> Btw. the strncpy would cause a small memory leak.
> 
> I don't see that at the moment. Can you explain that? Just curious.

Sorry, I misread the code, the memory where you copy to is already allocated, it
is fine.

Bye, Bernhard.


-- 

Visit my homepage http://www.berniw.org
Official TORCS racing: The TORCS Racing Board, http://www.berniw.org/trb

Hi Bernhard (and others),

On Sunday 8 October 2006 23:54, Bernhard Wymann wrote:
> Hi Mart
>
> > I have attached a patch which resolves this issue(s).
>
> Hmm, if nobody uses it, why not just remove it?

That is of course also a solution. I don't see directly what a bot can do with 
this information. Torcs does compile correctly without that field.

I use it for the track records, but because the race has ended when I look to 
those records, there are other ways to find out the category of the car.

> Btw. the strncpy would cause a small memory leak.

I don't see that at the moment. Can you explain that? Just curious.

> Thank you for your report. 
>
> Bye, Bernhard.

Regards,

Mart

Hi Mart

> I have attached a patch which resolves this issue(s).

Hmm, if nobody uses it, why not just remove it? Btw. the strncpy would cause a
small memory leak. Thank you for your report.

Bye, Bernhard.

-- 

Visit my homepage http://www.berniw.org
Official TORCS racing: The TORCS Racing Board, http://www.berniw.org/trb

Hi all,

I think there might be a problem with the category in the car's structure. 

The first problem is the define in src/interfaces/car.h. It defines (line 97) 
that "_category" is "info.cartegory" (notice the 'r' between "ca" 
and "tegory"). But grepping in the source code reveals that this is the only 
occurrence of cartegory.

I also think it is never initialized. I expect it in 
src/libs/raceengineclient/raceinit.cpp around line 573, because the category 
is obtained from the xml-file there. 

I have attached a patch which resolves this issue(s).

BTW, this define seems to be in there since the first commit of car.h five 
years ago.

Regards,

Mart